[RLlib] Move connectors creation code to single point in RolloutWorker #29064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
ArturNiederfahrenhorst
requested review from
sven1977,
gjoliver,
avnishn,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
ArturNiederfahrenhorst
changed the title
gjoliver
approved these changes
Oct 5, 2022
|
can you take a look at the failed tests? test_rollout_worker looks suspicious. |
|
test_rollout_worker was marked as flakey and according to https://flakey-tests.ray.io/ has already been flakey. I can't reproduce an error on my side. |
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
7 tasks
krfricke
added a commit
that referenced
this pull request
Oct 7, 2022
…29185) Some PRs (e.g. #29064) only change a single file but trigger the full test suite. The reason is likely that we have a stale master head ref. By fetching the latest head, we should be able to see more accurate results here and avoid running too many tests. Signed-off-by: Kai Fricke <[email protected]>
|
Can it be merged? What's the remaing work here? |
|
No, thank you. Not a pressing change. |
|
Cool, removed as a blocker for branch cut. |
| @@ -1905,9 +1868,24 @@ def _build_policy_map( | |||
| merged_conf, | |||
| ) | |||
|
|
|||
| if connectors_enabled and name in self.policy_map: | |||
| create_connectors_for_policy(self.policy_map[name], policy_config) | |||
| new_policy = self.policy_map[name] | |||
There was a problem hiding this comment.
_build_policy_map is called in add_policy and in init.
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…ay-project#29185) Some PRs (e.g. ray-project#29064) only change a single file but trigger the full test suite. The reason is likely that we have a stale master head ref. By fetching the latest head, we should be able to see more accurate results here and avoid running too many tests. Signed-off-by: Kai Fricke <[email protected]> Signed-off-by: Weichen Xu <[email protected]>
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
ray-project#29064) Signed-off-by: Artur Niederfahrenhorst <[email protected]> Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artur Niederfahrenhorst [email protected]
Why are these changes needed?
My first connectors/filters PR had two spots to have connectors, where there should be only one ideally.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.