[datasets] Add select_columns API to allow users to select a subset of columns #29081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyitsmui
requested review from
ericl,
scv119,
clarkzinzow,
jjyao,
jianoaix and
c21
as code owners
Signed-off-by: Michael Mui <[email protected]>
Signed-off-by: Michael Mui <[email protected]>
Signed-off-by: Michael Mui <[email protected]>
Signed-off-by: Michael Mui <[email protected]>
Signed-off-by: Michael Mui <[email protected]>
heyitsmui
force-pushed
the
27667-select-columns
branch
from
a86e109
to
4cce85f
Compare
|
hey @jianoaix can you help take a look? have addressed the comments in my draft PR - one thing i may still add is some schema validation check to see if users a selecting columns outside of the dataset schema |
c21
reviewed
Oct 5, 2022
jianoaix
added
the
@author-action-required
Signed-off-by: Michael Mui <[email protected]>
jianoaix
reviewed
Oct 12, 2022
There was a problem hiding this comment.
The implementation looks good!
Can you add this API to python/ray/data/dataset_pipeline.py as well?
Also we need to update the documentation:
- The Basic Transformations section in https://docs.ray.io/en/master/data/api/dataset.html
- Similarly in https://docs.ray.io/en/master/data/api/dataset_pipeline.html
…taset_pipeline, and update docs Signed-off-by: Michael Mui <[email protected]>
heyitsmui
requested review from
shrekris-anyscale,
sihanwang41,
architkulkarni,
xwjiang2010,
Yard1,
wuisawesome,
DmitriGekhtman,
pcmoritz,
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad,
kouroshHakha,
fishbone,
stephanie-wang,
suquark,
ijrsvt,
AmeerHajAli,
ckw017,
jovany-wang,
kfstorm,
raulchen,
WangTaoTheTonic and
robertnishihara
as code owners
|
@jianoaix i just rebased and fixed the merging issues in test_dataset_pipeline |
|
@c21 Yes, underlying pandas will raise a KeyError e.g. KeyError: "['dummy_col'] not in index" which is intuitive enough for user to figure out which columns to remove. |
|
thanks @heyitsmui ! |
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…f columns (ray-project#29081) Provide a new select_columns API to allow users to flexibly select a subset of existing columns. Added a new select_columns API within Dataset that uses map_batches to invoke the select method of each block. Added a new select_columns API within DatasetPipeline that apply Dataset.select_columns to each dataset/window in this pipeline. Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Provide a new
select_columnsAPI to allow users to flexibly select a subset of existing columns.Added a new
select_columnsAPI withinDatasetthat usesmap_batchesto invoke theselectmethod of each block. Added a newselect_columnsAPI withinDatasetPipelinethat applyDataset.select_columnsto each dataset/window in this pipeline.Related issue number
Closes #27667
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.