Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] Add Tuner.get_results() to retrieve results after restore #29083

Merged
merged 4 commits into from
Oct 6, 2022

Conversation

krfricke
Copy link
Contributor

@krfricke krfricke commented Oct 5, 2022

Why are these changes needed?

At the moment, we need to call tuner.fit() to retrieve results. This PR adds a method Tuner.get_results() that will return the results again after fitting. It can also be used after restoring a run to get results without calling fit() (and potentially resuming failed trials).

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Kai Fricke added 2 commits October 5, 2022 10:24
Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Kai Fricke <[email protected]>
@krfricke krfricke merged commit b510640 into ray-project:master Oct 6, 2022
@krfricke krfricke deleted the tune/tuner-results branch October 6, 2022 15:01
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
…-project#29083)

At the moment, we need to call `tuner.fit()` to retrieve results. This PR adds a method `Tuner.get_results()` that will return the results again after fitting. It can also be used after restoring a run to get results without calling `fit()` (and potentially resuming failed trials).

Signed-off-by: Kai Fricke <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants