[Core][Core-worker] fix the initialization/destruction order between reference_counter_ and node change subscription. #29108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scv119
changed the title
scv119
changed the title
rkooo567
approved these changes
Oct 6, 2022
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…reference_counter_ and node change subscription. (ray-project#29108) Why are these changes needed? we experienced segfault in core worker recently in some of our nightly tests. As we investigated this is likely caused by that when we get a callback from gcs client that the node has changed, the underlining reference_counter_ which handles the changed callback is not initialized (likely) or already being destructed. Fix: ensure reference_counter_ is initialized before the callback is registered, capture the shared ownership of reference_counter in the callback. we should be able to fix the bug. Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
we experienced segfault in core worker recently in some of our nightly tests. As we investigated this is likely caused by that when we get a callback from gcs client that the node has changed, the underlining reference_counter_ which handles the changed callback is not initialized (likely) or already being destructed.
Fix:
we should be able to fix the bug.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.