[Serve][Doc] Direct Ingress #29149
Merged
[Serve][Doc] Direct Ingress #29149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sihanwang41
requested review from
edoakes,
simon-mo,
jiaodong,
shrekris-anyscale and
a team
as code owners
sihanwang41
force-pushed
the
gRPC_doc
branch
3 times, most recently
from
f467f70
to
db4fc65
Compare
Signed-off-by: Sihan Wang <[email protected]>
architkulkarni
approved these changes
Oct 7, 2022
|
Please lmk once you addressed @architkulkarni's comments |
Signed-off-by: Sihan Wang <[email protected]>
simon-mo
requested changes
Oct 7, 2022
There was a problem hiding this comment.
One major issue we didn't explain is why would people use Serve's gRPC or bring their own gRPC schema. We should add the following paragraphs:
- What's the benefit of using gRPC: performance, standardization, binary protocol
- gRPC (builtin or BYO) an entrypoint to Serve's model scaling and deployment graph feature. (We should have examples about that here. Can we have the custom gRPC call a deployment graph?)
- What does
is_driver_deploymentmean? (We should say it is experimental)
dmatrix
approved these changes
Oct 8, 2022
|
|
||
| * use Serve's internal gRPC schema to send traffic | ||
| * bring your own gRPC schema into your Serve application | ||
|
|
There was a problem hiding this comment.
Or have a link to the gRPC documentation.
|
Hi @sihanwang41 - could you address the comment? |
Signed-off-by: Sihan Wang <[email protected]>
|
ping on my suggested edits... |
Signed-off-by: Sihan Wang <[email protected]>
Done! Sorry I miss the comments you left in the second round |
simon-mo
approved these changes
Oct 13, 2022
sihanwang41
added a commit
to sihanwang41/ray
that referenced
this pull request
Oct 14, 2022
7 tasks
rickyyx
pushed a commit
that referenced
this pull request
Oct 17, 2022
2 tasks
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sihan Wang [email protected]
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.