[Serve] Add serve_deployment_replica_healthy
gauge to check whether deployment replicas are healthy
#29154
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The Serve controller periodically health checks deployment replicas and restarts them if they're unhealthy. However, this info is only exposed in the controller's logs, which makes it hard to observe.
This change adds a new gauge,
serve_deployment_replica_healthy
, to track whether deployment replicas are healthy. The gauge is 1 when the replica is healthy and 0 when unhealthy.Related issue number
N/A
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.test_serve_metrics_for_successful_connection
intest_metrics.py
is updated to check for the newserve_deployment_replica_healthy
metric.