Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Fix policy restore. Avoid keyward params. (#29227) #29251

Merged
merged 1 commit into from
Oct 13, 2022
Merged

[RLlib] Fix policy restore. Avoid keyward params. (#29227) #29251

merged 1 commit into from
Oct 13, 2022

Conversation

gjoliver
Copy link
Member

Signed-off-by: Jun Gong [email protected]

Why are these changes needed?

Cherry pick a fix for the broken policy checkpoint loading functionality.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [*] Unit tests
    • Release tests
    • This PR is not tested :(

@gjoliver gjoliver added release-blocker P0 Issue that blocks the release v2.1.0-pick labels Oct 12, 2022
@rickyyx
Copy link
Contributor

rickyyx commented Oct 13, 2022

Could the TLs help approve this? @gjoliver

richardliaw
richardliaw approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@richardliaw richardliaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test pls

@gjoliver
Copy link
Member Author

test pls

ack. I will add a test now in MASTER.

@rickyyx
Copy link
Contributor

rickyyx commented Oct 13, 2022

Will you create another cherry pick PR with tests? Or should I merge this?

@gjoliver
Copy link
Member Author

please merge this. we don't need to pick the test into this release branch.

@rickyyx
Copy link
Contributor

rickyyx commented Oct 13, 2022

Is /rllib:connectors/tests/test_agent being fixed/tracked in other PRs/issues?

@gjoliver
Copy link
Member Author

Is /rllib:connectors/tests/test_agent being fixed/tracked in other PRs/issues?

this is one of the tests that are flaky due to infra issues.
I don't know what we can fix for those cases.

@rickyyx
Copy link
Contributor

rickyyx commented Oct 13, 2022

Is /rllib:connectors/tests/test_agent being fixed/tracked in other PRs/issues?

this is one of the tests that are flaky due to infra issues. I don't know what we can fix for those cases.

Gotcha, thanks! I will yolo as for now then - and open issues if this shows up in CI main branch.

@rickyyx rickyyx merged commit a0ba4f2 into releases/2.1.0 Oct 13, 2022
@rickyyx rickyyx deleted the pick_policy_restore branch October 13, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardliaw richardliaw richardliaw approved these changes

@sven1977 sven1977 Awaiting requested review from sven1977 sven1977 is a code owner

@avnishn avnishn Awaiting requested review from avnishn avnishn is a code owner

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst ArturNiederfahrenhorst is a code owner

@smorad smorad Awaiting requested review from smorad

@maxpumperla maxpumperla Awaiting requested review from maxpumperla maxpumperla is a code owner

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha kouroshHakha is a code owner

@krfricke krfricke Awaiting requested review from krfricke krfricke is a code owner

Assignees

@richardliaw richardliaw

@rickyyx rickyyx

Labels
release-blocker P0 Issue that blocks the release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gjoliver @rickyyx @richardliaw