[AIR] [Release] Fix air_benchmark_pytorch_training_e2e_gpu_1x1_20gb #29326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amog Kamsetty <[email protected]>
Signed-off-by: Amog Kamsetty <[email protected]>
Signed-off-by: Amog Kamsetty <[email protected]>
matthewdeng
approved these changes
Oct 14, 2022
jiaodong
reviewed
Oct 14, 2022
| # Fix fixed synthetic value for perf benchmark purpose | ||
| df.loc[:, "label"] = df["label"].map(lambda _: 1) | ||
| df = pd.DataFrame( | ||
| {"image": [preprocess(image) for image in batch], "label": [1] * len(batch)} |
There was a problem hiding this comment.
wait do we still need to return a DataFrame here ?
There was a problem hiding this comment.
No probably not, but I'm just following what was recommended in this PR: https://github.com/ray-project/ray/pull/29177/files#diff-e2bccb297d421f0dcff1892c4f23993064f52b17710787c41c3a2ae9dbc84159L13
#29177 should have updated these release tests but it was missed.
We should do another round making sure all the docs, examples, and tests are consistent with each other.
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…ay-project#29326) Signed-off-by: Amog Kamsetty [email protected] Changes to the release test to fix breaking read_images changes Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amog Kamsetty [email protected]
Changes to the release test to fix breaking
read_imageschangesCloses #29240
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.