Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Doc] Revamp ray core design patterns doc [13/n]: nested tasks #29342

Merged
merged 11 commits into from
Oct 18, 2022
Merged

[Doc] Revamp ray core design patterns doc [13/n]: nested tasks #29342

merged 11 commits into from
Oct 18, 2022

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Oct 13, 2022

Signed-off-by: Jiajun Yao [email protected]

Why are these changes needed?

  • Edit pass: make the patter generic for nested tasks instead of just recursive tasks.
  • Move the code to doc_code

Related issue number

#27048

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@jjyao jjyao marked this pull request as ready for review October 14, 2022 03:18
@jjyao jjyao requested a review from a team as a code owner October 14, 2022 03:18
@jjyao jjyao changed the title [Doc] Revamp ray core design patterns doc [13/n]: tree of tasks [Doc] Revamp ray core design patterns doc [13/n]: nested tasks Oct 17, 2022
stephanie-wang
stephanie-wang approved these changes Oct 18, 2022
View reviewed changes
doc/source/ray-core/patterns/nested-tasks.rst Outdated Show resolved Hide resolved
doc/source/ray-core/patterns/nested-tasks.rst Outdated Show resolved Hide resolved
doc/source/ray-core/patterns/nested-tasks.rst Outdated Show resolved Hide resolved
doc/source/ray-core/patterns/nested-tasks.rst Outdated Show resolved Hide resolved
@jjyao jjyao merged commit 98e9186 into ray-project:master Oct 18, 2022
@jjyao jjyao deleted the jjyao/tree branch October 18, 2022 19:44
jjyao added a commit that referenced this pull request Oct 24, 2022
@jjyao @stephanie-wang
[Doc] Revamp ray core design patterns doc [13/n]: nested tasks (#29342)
e770bdf 
- Edit pass: make the patter generic for nested tasks instead of just recursive tasks.
- Move the code to doc_code

Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: Stephanie Wang <[email protected]>
Co-authored-by: Stephanie Wang <[email protected]>
@jjyao jjyao mentioned this pull request Oct 24, 2022
Merged
7 tasks
jjyao added a commit that referenced this pull request Oct 25, 2022
@jjyao
[CherryPick] [Doc] Cherry pick #29342 and #29469 (#29633)
b7e3378
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@jjyao @stephanie-wang @WeichenXu123
[Doc] Revamp ray core design patterns doc [13/n]: nested tasks (ray-p…
c310bb8 
…roject#29342)

- Edit pass: make the patter generic for nested tasks instead of just recursive tasks.
- Move the code to doc_code

Signed-off-by: Jiajun Yao <[email protected]>
Signed-off-by: Stephanie Wang <[email protected]>
Co-authored-by: Stephanie Wang <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanie-wang stephanie-wang stephanie-wang approved these changes

Assignees

@stephanie-wang stephanie-wang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjyao @stephanie-wang