Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datasets] Clean up accessing_datasets.py #29460

Merged

Conversation

bveeramani
Copy link
Member

Signed-off-by: Balaji [email protected]

Why are these changes needed?

#26935 removed accessing-datasets.rst. Now, most of the code in doc_code/accessing-datasets.py is unused.

I've cleaned up the file accordingly.

Related issue number

See #26935

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani bveeramani changed the title Initial commit [Datasets] Clean up accessing-datasets.py Oct 19, 2022
@bveeramani bveeramani changed the title [Datasets] Clean up accessing-datasets.py [Datasets] Clean up accessing_datasets.py Oct 19, 2022
@ericl ericl merged commit a6b242f into ray-project:master Oct 19, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
ray-project#26935 removed `accessing-datasets.rst`. Now, most of the code in `doc_code/accessing-datasets.py` is unused.

I've cleaned up the file accordingly.

Signed-off-by: Weichen Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants