Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] RLlib-in-60sec and other doc upgrades. #29544

Merged
merged 3 commits into from
Oct 21, 2022
Merged

[RLlib] RLlib-in-60sec and other doc upgrades. #29544

merged 3 commits into from
Oct 21, 2022

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Oct 21, 2022 •
edited
Loading

RLlib-in-60sec and other doc upgrades (new checkpoint docs fixed).

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
eb515f7 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
82dc238 
Signed-off-by: sven1977 <[email protected]>
maxpumperla
maxpumperla approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@maxpumperla maxpumperla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool! linter still failing, otherwise good to go.

@sven1977
wip
8f6c4d1 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 merged commit bf4894d into ray-project:master Oct 21, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@sven1977 @WeichenXu123
[RLlib] RLlib-in-60sec and other doc upgrades. (ray-project#29544)
5e421c2 
Signed-off-by: Weichen Xu <[email protected]>
@sven1977 sven1977 deleted the rllib_in_60sec_and_other_doc_upgrades branch June 2, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpumperla maxpumperla maxpumperla approved these changes

@gjoliver gjoliver Awaiting requested review from gjoliver

@avnishn avnishn Awaiting requested review from avnishn

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

@smorad smorad Awaiting requested review from smorad

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@maxpumperla maxpumperla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @maxpumperla