-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] [docs] CLI user guide #29661
Conversation
Signed-off-by: Max Pumperla <[email protected]>
@@ -1,4 +1,3 @@ | |||
# config for quick cli testing. does not give meaningful results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, True, though, should we make this example not learn to the end (e.g. 150 reward)? It's pretty quick with SimpleQ. Otherwise, it's not really a "tuned" example :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, good point. maybe we should move these files to another folder or so? In this case you're absolutely right, but I really want to have a couple of test files that return in a manner of seconds, not minutes - and give me a checkpoint to evaluate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sven1977 ok, I reset the reward for these examples back to 150, makes sense. if we need other, quicker configs, we can add them later.
@@ -0,0 +1,336 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesomeness! :) Dumb question. Why not rst, but md?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ha, thanks. well, a) I personally prefer markdown, b) the margin
directive doesn't work in rst, and c) the yaml header in the file makes the whole thing an executable format.
It's essentially a jupyter notebook in disguise. The serve team almost exclusively used md
by now, and I just wanted to give a reference example for you guys to work off of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for this great PR @maxpumperla ! The CLI is really dope now.
Just 2 questions & nits, then happy to merge.
Signed-off-by: Max Pumperla <[email protected]>
Signed-off-by: Max Pumperla <[email protected]>
Signed-off-by: Max Pumperla <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
Best to simply check the page itself: https://ray--29661.org.readthedocs.build/en/29661/rllib/rllib-cli.html