Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Move all config validation logic into AlgorithmConfig classes. #29854

Merged
merged 39 commits into from
Nov 4, 2022
Merged

[RLlib] Move all config validation logic into AlgorithmConfig classes. #29854

merged 39 commits into from
Nov 4, 2022

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Oct 31, 2022 •
edited
Loading

Move all config validation logic into AlgorithmConfig classes.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
141efa8 
Signed-off-by: sven1977 <[email protected]>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into algo…
82d5dae 
…_configs_next_steps_3
@sven1977
LINT
31fa93a 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
4a0f858 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
833be55 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
028bfd6 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
a2d99d4 
Signed-off-by: sven1977 <[email protected]>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into algo…
f8ac69e 
…_configs_next_steps_4
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into algo…
78d439a 
…_configs_next_steps_3
@sven1977
wip
0f67ef5 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
d68c480 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
1e832b6 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
e7a5660 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
0801205 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
4134dab 
Signed-off-by: sven1977 <[email protected]>
@sven1977
Merge branch 'algo_configs_next_steps_3' into algo_configs_next_steps_4
213f8ae
@sven1977
wip
cc83c43 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
575f17d 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
35ca9e5 
Signed-off-by: sven1977 <[email protected]>
maxpumperla
maxpumperla approved these changes Oct 31, 2022
View reviewed changes
Copy link
Contributor

@maxpumperla maxpumperla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Great step forward.

@sven1977
wip
942c2ca 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
7ceba17 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
b6f94b0 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
8f94401 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
aea75e1 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
9493090 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
e502cb5 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
26821ce 
Signed-off-by: sven1977 <[email protected]>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into algo…
db1e957 
…_configs_next_steps_4

Signed-off-by: sven1977 <[email protected]>

# Conflicts:
#	rllib/algorithms/algorithm.py
#	rllib/algorithms/dreamer/dreamer.py
#	rllib/algorithms/maddpg/maddpg.py
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into algo…
dd9d557 
…_configs_next_steps_4

Signed-off-by: sven1977 <[email protected]>

# Conflicts:
#	rllib/algorithms/algorithm.py
#	rllib/algorithms/dreamer/dreamer.py
#	rllib/algorithms/maddpg/maddpg.py
@sven1977
wip
067cbd9 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
9d300e2 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
001cfe8 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
a126727 
Signed-off-by: sven1977 <[email protected]>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into algo…
c0bd63a 
…_configs_next_steps_4
@sven1977
wip
f1af880 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
9475568 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 mentioned this pull request Nov 4, 2022
Merged
7 tasks
@sven1977
wip
d7228cd 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
2ccab68 
Signed-off-by: sven1977 <[email protected]>
@sven1977
wip
a9a7913 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 merged commit 2ed09c5 into ray-project:master Nov 4, 2022
@avnishn avnishn mentioned this pull request Nov 8, 2022
Merged
7 tasks
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@sven1977 @WeichenXu123
[RLlib] Move all config validation logic into AlgorithmConfig classes. (
d6b7679 
ray-project#29854)

Signed-off-by: Weichen Xu <[email protected]>
@sven1977 sven1977 deleted the algo_configs_next_steps_4 branch June 2, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxpumperla maxpumperla maxpumperla approved these changes

@gjoliver gjoliver Awaiting requested review from gjoliver

@avnishn avnishn Awaiting requested review from avnishn

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

@smorad smorad Awaiting requested review from smorad

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@maxpumperla maxpumperla

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @maxpumperla