Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Fix cov matrix bug bandits #29867

Merged

Conversation

kouroshHakha
Copy link
Contributor

Why are these changes needed?

To fix the revert. #29846

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@kouroshHakha
Copy link
Contributor Author

let's see if this one fixes the issue. @gjoliver

Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
@kouroshHakha
Copy link
Contributor Author

@gjoliver The CI machines are extremely slow. The test_bandit takes 3 min on my laptop to run, on CI it takes 700 seconds.

@gjoliver
Copy link
Member

gjoliver commented Nov 1, 2022

@gjoliver The CI machines are extremely slow. The test_bandit takes 3 min on my laptop to run, on CI it takes 700 seconds.

did we mark it exclusive?? I found that for almost all tests the require a ray cluster, we should mark them exclusive.

@kouroshHakha
Copy link
Contributor Author

@gjoliver The CI machines are extremely slow. The test_bandit takes 3 min on my laptop to run, on CI it takes 700 seconds.

did we mark it exclusive?? I found that for almost all tests the require a ray cluster, we should mark them exclusive.

This should not need a cluster. It's just extremely slow for some unknown reason.

@gjoliver
Copy link
Member

gjoliver commented Nov 1, 2022

test failures are known.

@gjoliver gjoliver merged commit e389e13 into ray-project:master Nov 1, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Kourosh Hakhamaneshi <[email protected]>
Co-authored-by: Avnish <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants