[Datasets] Print out Dataset statistics automatically after execution #29876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottjlee
requested review from
ericl,
scv119,
clarkzinzow,
jjyao,
jianoaix and
c21
as code owners
scottjlee
changed the title
c21
changed the title
|
Congrats @scottjlee for the first PR! As discussed offline, let's do several things:
|
Signed-off-by: Scott Lee <[email protected]>
Signed-off-by: Scott Lee <[email protected]>
Signed-off-by: Scott Lee <[email protected]>
Signed-off-by: Scott Lee <[email protected]>
Signed-off-by: Scott Lee <[email protected]> Signed-off-by: Scott Lee <[email protected]>
Signed-off-by: Scott Lee <[email protected]>
scottjlee
changed the title
c21
reviewed
Nov 2, 2022
Signed-off-by: Scott Lee <[email protected]>
c21
reviewed
Nov 2, 2022
Signed-off-by: Scott Lee <[email protected]>
c21
reviewed
Nov 2, 2022
Signed-off-by: Scott Lee <[email protected]>
clarkzinzow
reviewed
Nov 3, 2022
Signed-off-by: Scott Lee <[email protected]>
Signed-off-by: Scott Lee <[email protected]>
|
CI looks good, merging! |
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…ray-project#29876) Currently, the stats can only be printed manually via the Dataset.stats() method from user side. This is inconvenient during debugging as it adds overhead on the user side. We add functionality to automatically log Dataset summary statistics after execution of each stage, which can be enabled via a new configuration in DatasetContext, enable_auto_log_stats. Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Currently, the stats can only be printed manually via the Dataset.stats() method from user side. This is inconvenient during debugging as it adds overhead on the user side. We add functionality to automatically log
Datasetsummary statistics after execution of each stage, which can be enabled via a new configuration inDatasetContext,enable_auto_log_stats.Related issue number
Closes #29560
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.