Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Fix ray-data-bulk-ingest-out-of-core-benchmark weekly test #29886

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

bveeramani
Copy link
Member

@bveeramani bveeramani commented Nov 1, 2022

Why are these changes needed?

app_config.yaml was renamed app_config_oom.yaml in #29679, but release_tests.yaml wasn't updated. See #29885.

Related issue number

Closes #29885

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@bveeramani bveeramani changed the title [CI] Fix ray-data-bulk-ingest-out-of-core-benchmark [CI] Fix ray-data-bulk-ingest-out-of-core-benchmark weekly test Nov 1, 2022
Copy link
Contributor

@clarng clarng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a race between the PRs that got merged the same day

#29730
#29679

cc @stephanie-wang @scv119

@krfricke
Copy link
Contributor

krfricke commented Nov 1, 2022

@bveeramani minor nit, but could you signoff your commits to enable DCO? See the failing test here.

There is an option to enable this per default, which is probably the easiest way to do this in the future. Thanks!

@krfricke krfricke merged commit 8422010 into ray-project:master Nov 1, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
…project#29886)

`app_config.yaml` was renamed `app_config_oom.yaml` in ray-project#29679, but `release_tests.yaml` wasn't updated. See ray-project#29885.

Signed-off-by: Weichen Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] ray-data-bulk-ingest-out-of-core-benchmark weekly test fails
3 participants