[Serve][Cli] Update deploy message in 'serve run' #29897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sihanwang41
force-pushed
the
update_run_cli_print
branch
from
142398d
to
f47ebe0
Compare
shrekris-anyscale
approved these changes
Nov 1, 2022
There was a problem hiding this comment.
Nice work! There are a few tests in test_cli.py that use "Deployed successfully" (e.g. test_deploy) to determine if a request was sent successfully. Could you update those, so they pass CI?
Edit: never mind, this applies to serve deploy, not serve run.
Signed-off-by: Sihan Wang <[email protected]>
Signed-off-by: Sihan Wang <[email protected]>
sihanwang41
force-pushed
the
update_run_cli_print
branch
from
f47ebe0
to
77f436e
Compare
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sihan Wang [email protected]
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.