[rllib] stopper support for python based training #29972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Pumperla <[email protected]>
maxpumperla
requested review from
sven1977,
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad,
kouroshHakha and
krfricke
as code owners
sven1977
reviewed
Nov 3, 2022
| @@ -102,10 +102,12 @@ def run(example_id: str = typer.Argument(..., help="Example ID to run.")): | |||
| example_file = get_example_file(example_id) | |||
| example_file, temp_file = download_example_file(example_file) | |||
| file_type = example.get("file_type", SupportedFileType.yaml) | |||
| stop = example.get("stop", "{}") | |||
There was a problem hiding this comment.
Btw, sorry, unrelated to this PR, BUT can we automate the file_type recognition (instead of making it yaml by default, detect type from file extension).
sven1977
reviewed
Nov 3, 2022
sven1977
reviewed
Nov 3, 2022
sven1977
reviewed
Nov 3, 2022
sven1977
approved these changes
Nov 3, 2022
There was a problem hiding this comment.
Looks great, thanks for the PR.
Please address the questions and nits before merging. Thx @maxpumperla !
Signed-off-by: Max Pumperla <[email protected]>
Signed-off-by: Max Pumperla <[email protected]>
Signed-off-by: Max Pumperla <[email protected]>
Signed-off-by: Max Pumperla <[email protected]>
Signed-off-by: Max Pumperla <[email protected]>
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
Signed-off-by: Max Pumperla <[email protected]> Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rllib trainpython files are now cleaner, split out Tune-specificstopconditions. So, you can now write:I updated a couple of example scripts / tuned examples to show-case this (and added a test). I think at this point running Python files feels like the best way to go (as opposed to YAML etc.).
Bonus: assuming we can pull off the conversion of all current yaml files to python, I think this would open up a really nice way of exposing these algo configs as proper examples in our docs. This section still bothers me.