[RLlib] Enable .py files with AlgorithmConfig objects in them to be run by our run_regression_test.py script.
#29974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sven1977 <[email protected]>
sven1977
requested review from
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
sven1977
added
the
tests-ok
maxpumperla
reviewed
Nov 4, 2022
rllib/tests/run_regression_tests.py
Outdated
| # Path given -> Get all yaml files in there via rglob. | ||
| elif os.path.isdir(abs_path): | ||
| files = rllib_dir.rglob(args.dir + "/*.yaml") |
There was a problem hiding this comment.
shouldn't this also look for py files? or do we want to make this a follow-up?
There was a problem hiding this comment.
Oh, great catch! Let me fix this.
There was a problem hiding this comment.
Fixed, pending tests ...
maxpumperla
reviewed
Nov 4, 2022
| # `load_experiments_from_file` function (everything from "/ray/rllib" on). | ||
| if file.endswith(".py"): | ||
| file = re.sub("^.*/ray/rllib/", "ray/rllib/", file) | ||
| experiments = load_experiments_from_file(file, SupportedFileType.python) |
maxpumperla
approved these changes
Nov 4, 2022
Signed-off-by: sven1977 <[email protected]>
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…un by our `run_regression_test.py` script. (ray-project#29974) Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: sven1977 [email protected]
Enable .py files with AlgorithmConfig objects in them to be run by our
run_regression_test.pyscript.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.