[Datasets] Convert between block and batch correctly for map_groups #30172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c21
requested review from
ericl,
scv119,
clarkzinzow,
jjyao and
jianoaix
as code owners
Signed-off-by: Cheng Su <[email protected]>
jianoaix
approved these changes
Nov 10, 2022
jianoaix
approved these changes
Nov 10, 2022
| builder.add_block(applied) | ||
| group_block = block_accessor.slice(start, end) | ||
| group_block_accessor = BlockAccessor.for_block(group_block) | ||
| group_batch = group_block_accessor.to_batch_format(batch_format) |
There was a problem hiding this comment.
Briefly comment there is batch -> block -> batch trip needed here?
There was a problem hiding this comment.
@jianoaix - sounds good, added.
Signed-off-by: Cheng Su <[email protected]>
c21
added
the
tests-ok
|
thanks for the quick fix ! This can make one of our cv user's AIR onboarding UX much cleaner. |
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…ay-project#30172) This is to fix issue found in ray-project#30102, where user can do ds.groupby("key").map_groups(fn, batch_format="numpy"). We need to correctly convert between block and batch in map_groups to handle it. Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Cheng Su [email protected]
Why are these changes needed?
This is to fix issue found in #30102, where user can do ds.groupby("key").map_groups(fn, batch_format="numpy"). We need to correctly convert between block and batch in map_groups to handle it.
Related issue number
Closes #30102
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.