Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tune] Remove hard deprecated SyncClient/Syncer #30253

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Nov 14, 2022

Signed-off-by: Antoni Baum [email protected]

Why are these changes needed?

Removes hard deprecated SyncClient/Syncer modules for 2.2.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@amogkam
Copy link
Contributor

amogkam commented Nov 14, 2022

failing test is unrelated, going to merge

@amogkam amogkam merged commit 134fa08 into ray-project:master Nov 14, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
Removes hard deprecated SyncClient/Syncer modules for 2.2.

Signed-off-by: Antoni Baum <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants