[RLlib] Fix RolloutWorker filter syncing #30257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
ArturNiederfahrenhorst
requested review from
gjoliver,
avnishn,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
| @@ -144,7 +144,7 @@ def maybe_get_filters_for_syncing(rollout_worker, policy_id): | |||
| ] | |||
| # There can only be one filter at a time | |||
| if filter_connectors: | |||
| assert len(SyncedFilterAgentConnector) == 1, ( | |||
There was a problem hiding this comment.
This line was never executed
| @@ -445,7 +445,11 @@ def __getitem__(self, key: Union[str, int, type]): | |||
| elif isinstance(key, int): | |||
| return [self.connectors[key]] | |||
| elif isinstance(key, type): | |||
| key = key.__name__ | |||
There was a problem hiding this comment.
This makes it so that we can fetch all SynchedFilters.
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
gjoliver
approved these changes
Nov 16, 2022
|
Test failures look unrelated |
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
Signed-off-by: Artur Niederfahrenhorst <[email protected]> Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artur Niederfahrenhorst [email protected]
Why are these changes needed?
When creating filter connectors, these are not properly added to the RolloutWorker's filters.
That is because we scanned for them by class name, rather than with issubclass.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.