[Train] Fix prepare_data_loader with enable_reproducibility
#30266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antoni Baum <[email protected]>
amogkam
approved these changes
Nov 15, 2022
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…project#30266) Calling train.torch.enable_reproducibility before train.torch.prepare_data_loader causes an exception to be raised of the num_workers in DataLoader is bigger than 0 and the worker_init_fn in DataLoader is not set. The exception is caused by the worker_init_fn, which has a value of None, being used as a callable in seeded_worker_init_fn. This was untested. This PR fixes this oversight and ensures that this is tested in CI (and also removes a duplicate test in the process). Signed-off-by: Antoni Baum <[email protected]> Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antoni Baum [email protected]
Why are these changes needed?
Calling
train.torch.enable_reproducibilitybeforetrain.torch.prepare_data_loadercauses an exception to be raised of thenum_workersinDataLoaderis bigger than 0 and theworker_init_fninDataLoaderis not set. The exception is caused by theworker_init_fn, which has a value ofNone, being used as a callable inseeded_worker_init_fn. This was untested.This PR fixes this oversight and ensures that this is tested in CI (and also removes a duplicate test in the process).
Related issue number
Closes #30247
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.