[RLlib] [Connectors] Fix test multi agent sample sync remote connectors #30307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The agent collector wasn't adding rnn initial states to training batches. This caused the initial states to be improperly affected, which we know breaks test_lstm and test_multi_agent_env. Signed-off-by: Avnish <[email protected]>
avnishn
requested review from
sven1977,
gjoliver,
ArturNiederfahrenhorst,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]> Co-authored-by: Artur Niederfahrenhorst <[email protected]>
avnishn
force-pushed
the
fix_test_multi_agent_sample_sync_remote_connectors
branch
from
32c51cc
to
9fca30d
Compare
The agent collector wasn't adding rnn initial states to training batches. This caused the initial states to be improperly affected, which we know breaks test_lstm and test_multi_agent_env. Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]> Co-authored-by: Artur Niederfahrenhorst <[email protected]>
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
…shn/ray into fix_test_multi_agent_sample
Signed-off-by: Avnish <[email protected]>
…y-project#30316) This shows the development workflow on how to incorporate API examples into the documentation and how to run doctests locally.
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]>
avnishn
force-pushed
the
fix_test_multi_agent_sample_sync_remote_connectors
branch
from
12f68fb
to
dc65f06
Compare
…test_multi_agent_sample_sync_remote_connectors
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]>
Signed-off-by: Avnish <[email protected]>
gjoliver
approved these changes
Nov 17, 2022
|
test failures are known. some of these are already fixed. |
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…rs (ray-project#30307) Signed-off-by: Avnish <[email protected]> Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.