Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] [Connectors] Fix test returning model based rollouts data connectors #30308

Merged
merged 16 commits into from
Nov 17, 2022
Merged

[RLlib] [Connectors] Fix test returning model based rollouts data connectors #30308

Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
a1b35a5
Agent collector isn't adding initial rnn state to training batch
avnishn Nov 15, 2022
c503e51
Merge branch 'master' of https://github.com/ray-project/ray into fix_…
avnishn Nov 15, 2022
4458195
Disable connectors globally enable in test
avnishn Nov 15, 2022
15eab94
remove accidental comment
avnishn Nov 15, 2022
667e8b2
Address review comments
avnishn Nov 15, 2022
a94e7a9
Merge branch 'master' of https://github.com/ray-project/ray into fix_…
avnishn Nov 15, 2022
e8fc768
Address comments
avnishn Nov 16, 2022
786ed3d
Fix check on timestep indices, episodes start at -1
avnishn Nov 15, 2022
fdc6dde
Temp
avnishn Nov 15, 2022
90d883d
fix for off by 1 issue
avnishn Nov 15, 2022
10a1c10
Add test in additional places for checking timestep numbering
avnishn Nov 16, 2022
9fca30d
Policy mapping function takes as a parameter episodes now
avnishn Nov 15, 2022
7881947
test_returning_model_based_rollouts_data is only compatible with the …
avnishn Nov 15, 2022
7dd872e
Merge branch 'master' of https://github.com/ray-project/ray into fix_…
avnishn Nov 17, 2022
edf044b
Remove other changes
avnishn Nov 17, 2022
edebe30
Lint
avnishn Nov 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions rllib/env/tests/test_multi_agent_env.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,8 @@ def is_recurrent(self):
self.assertEqual(batch["state_out_0"][i], h)

def test_returning_model_based_rollouts_data(self):
# TODO(avnishn): This test only works with the old api

class ModelBasedPolicy(DQNTFPolicy):
def compute_actions_from_input_dict(
self, input_dict, explore=None, timestep=None, episodes=None, **kwargs
Expand Down Expand Up @@ -416,6 +418,7 @@ def compute_actions_from_input_dict(
.rollouts(
rollout_fragment_length=5,
num_rollout_workers=0,
enable_connectors=False, # only works with old episode API
)
.multi_agent(
policies={"p0", "p1"},
Expand Down