Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jobs] [Doc] Add Jobs openapi spec and REST API documentation #30417

Merged
merged 10 commits into from
Nov 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion dashboard/modules/job/job_head.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,17 @@ async def close(self, ignore_error=True):


class JobHead(dashboard_utils.DashboardHeadModule):
"""Runs on the head node of a Ray cluster and handles Ray Jobs APIs."""
"""Runs on the head node of a Ray cluster and handles Ray Jobs APIs.

NOTE(architkulkarni): Please keep this class in sync with the OpenAPI spec at
`doc/source/cluster/running-applications/job-submission/openapi.yml`.
We currently do not automatically check that the OpenAPI
spec is in sync with the implementation. If any changes are made to the
paths in the @route decorators or in the Responses returned by the
methods (or any nested fields in the Responses), you will need to find the
corresponding field of the OpenAPI yaml file and update it manually, and
bump the version number in the yaml file and in this class's `get_version`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence is long. I would break it.

"update it manually." Also, bump the version number in the yaml file and in this class's get_version.

"""

# Time that we sleep while tailing logs while waiting for
# the supervisor actor to start. We don't know which node
Expand Down
1 change: 1 addition & 0 deletions doc/requirements-doc.txt
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ sphinxcontrib.yt==0.2.2
sphinx-sitemap==2.2.0
sphinx-thebe==0.1.1
autodoc_pydantic==1.6.1
sphinxcontrib-redoc==1.6.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a particular reason to pin the version here, just following what's been done for other sphinx extensions


# MyST
myst-parser==0.15.2
Expand Down
Loading