[AIR] Fix examples and tests to specify batch_format in BatchMapper
#30438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
amogkam
approved these changes
Nov 17, 2022
justinvyu
commented
Nov 17, 2022
| override_prep = BatchMapper(lambda x: x) | ||
| override_prep = BatchMapper( | ||
| lambda x: x, batch_format=predict_stage_batch_format | ||
| ) |
There was a problem hiding this comment.
Is it possible to add a unit test for this codepath? Test preprocessing before sending to a separate GPU stage to do prediction.
There was a problem hiding this comment.
There was a problem hiding this comment.
I see, I think the test was still pending and not showing up on the flaky tests earlier.
7 tasks
richardliaw
approved these changes
Nov 18, 2022
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…r` (ray-project#30438) Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Followup to #30366 to update remaining tests, examples, and doc code to specify a batch format (setting it to
pandas, which was the default before).Related issue number
Closes #30431
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.