[RLlib] Add backward compatibility to MeanStdFilter to restore from older checkpoints. #30439
Conversation
simonsays1980
requested review from
sven1977,
gjoliver,
avnishn,
ArturNiederfahrenhorst,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
…heckpoints. Signed-off-by: Simon Zehnder <[email protected]>
simonsays1980
force-pushed
the
meanstdfilter-backward-compatibility
branch
from
bece744
to
eb362bc
Compare
There was a problem hiding this comment.
Thanks for this contribution @simonsays1980 ! I actually changed the names here to make the code well readable but forgot about the compatibility.
| ) | ||
| other.std_array = ( | ||
| np.copy(self.std_array) if hasattr(self, "std_array") else np.copy(self._S) | ||
| ) |
There was a problem hiding this comment.
For reference, it was #27864 that made these changes. All changed attribute names seem to be covered here.
There was a problem hiding this comment.
Nit: A TODO that tells us to remove this additional code at some point. But it does not do any harm here either 😃
There was a problem hiding this comment.
I can add the nit :D
I also saw that we get often a DeprecationWarning with this class which could be overcome probably by choosing () instead of None in the shape arguments of numpy array ctors.
I could push that together into one smooth PR if needed
There was a problem hiding this comment.
Separate PRs for separate problems would be appreciated!
…ged 'shape=None' for 'shape=()' as interchangeability of 'None' and '()' will be deprecated and only '()' will stay. Signed-off-by: Simon Zehnder <[email protected]>
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.
|
stale
bot
added
the
stale
stale
bot
removed
the
stale
sven1977
changed the title
…lder checkpoints. (#30439)
…lder checkpoints. (ray-project#30439) Signed-off-by: tmynn <[email protected]>
…heckpoints.
Why are these changes needed?
Restoring in
Ray 2.0.1checkpoints from older versions whereMeanStdFilterwas used for training results in an error:AttributeError: other has no attribute named 'running_stats'The same goes for
self.mean_arrayandself.std_arraysimply because these attributes were named differently.This PR adds some safeguarding for backwards compatibility. I tested this with my own checkpoints from
Ray 2.0.0and it works.Related issue number
None. Faught with it, saw it, fixed it.
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.