Revert "Revert "[autoscaler][observability] Autoscaler emit cluster/pending logical resource metrics"" #30552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
October 27, 2022 20:16
added 2 commits
November 21, 2022 14:44
…ending logical resource metrics (ray-project#29820)" (ray-project#30551)" This reverts commit f9092dc.
wuisawesome
commented
Nov 21, 2022
| @@ -13,6 +13,9 @@ def observe(self, *args, **kwargs): | |||
| def inc(self, *args, **kwargs): | |||
| pass | |||
|
|
|||
| def labels(self, *args, **kwargs): | |||
There was a problem hiding this comment.
This is the only difference
DmitriGekhtman
approved these changes
Nov 21, 2022
|
Failures now really look unrelated. They all seem to be docs, test_runtime_env_complicated, test_cli or test_cancel which are all broken in master. |
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…ending logical resource metrics"" (ray-project#30552) See ray-project#29820 for most of the details of the PR. The only difference is improving the NullMetric stub to not fail when tagging labesl for metrics. This reverts commit f9092dc. Co-authored-by: Alex <[email protected]> Signed-off-by: Weichen Xu <[email protected]>
Capiru
pushed a commit
to Capiru/ray
that referenced
this pull request
Dec 22, 2022
…ending logical resource metrics"" (ray-project#30552) See ray-project#29820 for most of the details of the PR. The only difference is improving the NullMetric stub to not fail when tagging labesl for metrics. This reverts commit f9092dc. Co-authored-by: Alex <[email protected]> Signed-off-by: Capiru <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
See #29820 for most of the details of the PR.
The only difference is improving the
NullMetricstub to not fail when tagging labesl for metrics.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.