[core] Fix a corner case where GCS will crash when actor is deleted #30563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yi Cheng <[email protected]>
Signed-off-by: Yi Cheng <[email protected]>
|
Sadly I don't know how to test this one. This usually happens when GCS is overloaded (writing to table slow) and driver created a lot of actors and exits. Any ideas are welcome. |
scv119
approved these changes
Nov 22, 2022
|
test failure not releated |
fishbone
added a commit
to fishbone/ray
that referenced
this pull request
Nov 22, 2022
…ay-project#30563) When the lease is granted and writing to the table, if the actor is deleted, GCS is going to crash. This PR fix it by check the actor status first before creating the actor.
7 tasks
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…ay-project#30563) When the lease is granted and writing to the table, if the actor is deleted, GCS is going to crash. This PR fix it by check the actor status first before creating the actor. Signed-off-by: Weichen Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
When the lease is granted and writing to the table, if the actor is deleted, GCS is going to crash. This PR fix it by check the actor status first before creating the actor.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.