Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AIR] Fix reserved CPU warning if no CPUs are used #30598

Conversation

Yard1
Copy link
Member

@Yard1 Yard1 commented Nov 22, 2022

Signed-off-by: Antoni Baum [email protected]

Why are these changes needed?

If a ScalingConfig is configured to require no CPUs at all for a trial, TunerInternal._expected_utilization will encounter a divide by zero error. This can be encountered when using a GPU enabled trainer on Google Colab. This PR fixes this issue.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Copy link
Contributor

@amogkam amogkam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Yard1!

Signed-off-by: Antoni Baum <[email protected]>
@amogkam amogkam merged commit 6add452 into ray-project:master Nov 28, 2022
@Yard1 Yard1 deleted the fix_reserved_cpu_warning_if_no_cpus_are_required branch November 28, 2022 16:58
Yard1 added a commit to Yard1/ray that referenced this pull request Nov 28, 2022
If a ScalingConfig is configured to require no CPUs at all for a trial, TunerInternal._expected_utilization will encounter a divide by zero error. This can be encountered when using a GPU enabled trainer on Google Colab. This PR fixes this issue.

Signed-off-by: Antoni Baum <[email protected]>
xwjiang2010 pushed a commit that referenced this pull request Nov 28, 2022
If a ScalingConfig is configured to require no CPUs at all for a trial, TunerInternal._expected_utilization will encounter a divide by zero error. This can be encountered when using a GPU enabled trainer on Google Colab. This PR fixes this issue.

Signed-off-by: Antoni Baum <[email protected]>

Signed-off-by: Antoni Baum <[email protected]>
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
If a ScalingConfig is configured to require no CPUs at all for a trial, TunerInternal._expected_utilization will encounter a divide by zero error. This can be encountered when using a GPU enabled trainer on Google Colab. This PR fixes this issue.

Signed-off-by: Antoni Baum <[email protected]>
Signed-off-by: Weichen Xu <[email protected]>
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
If a ScalingConfig is configured to require no CPUs at all for a trial, TunerInternal._expected_utilization will encounter a divide by zero error. This can be encountered when using a GPU enabled trainer on Google Colab. This PR fixes this issue.

Signed-off-by: Antoni Baum <[email protected]>
Signed-off-by: tmynn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants