-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Datasets] Handle all Ray errors in task compute strategy. #30696
[Datasets] Handle all Ray errors in task compute strategy. #30696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to add a unit test for this?
Confirmed that this deflakes the test. @c21 I'm attempting to add a test that parametrizes ray/python/ray/data/tests/test_dataset.py Line 5118 in 8f3e22d
|
Test failures are unrelated, merging. |
…ct#30696) If a Ray error other than a RayTaskError is raised 1. while waiting for map tasks to finish, then we won't properly cancel other map tasks, 2. while waiting for map tasks to be cancelled, then we won't raise the correct (original) task failure exception. This PR fixes this by catching RayError in both cases, which is a superclass of RayTaskError, TaskCancelledError, and WorkerCrashedError (which may be raised during graceful task cancellation due to a Ray Core bug). This should deflake the test_select_columns test.
…30720) If a Ray error other than a RayTaskError is raised 1. while waiting for map tasks to finish, then we won't properly cancel other map tasks, 2. while waiting for map tasks to be cancelled, then we won't raise the correct (original) task failure exception. This PR fixes this by catching RayError in both cases, which is a superclass of RayTaskError, TaskCancelledError, and WorkerCrashedError (which may be raised during graceful task cancellation due to a Ray Core bug). This should deflake the test_select_columns test.
…ct#30696) If a Ray error other than a RayTaskError is raised 1. while waiting for map tasks to finish, then we won't properly cancel other map tasks, 2. while waiting for map tasks to be cancelled, then we won't raise the correct (original) task failure exception. This PR fixes this by catching RayError in both cases, which is a superclass of RayTaskError, TaskCancelledError, and WorkerCrashedError (which may be raised during graceful task cancellation due to a Ray Core bug). This should deflake the test_select_columns test. Signed-off-by: Weichen Xu <[email protected]>
…ct#30696) If a Ray error other than a RayTaskError is raised 1. while waiting for map tasks to finish, then we won't properly cancel other map tasks, 2. while waiting for map tasks to be cancelled, then we won't raise the correct (original) task failure exception. This PR fixes this by catching RayError in both cases, which is a superclass of RayTaskError, TaskCancelledError, and WorkerCrashedError (which may be raised during graceful task cancellation due to a Ray Core bug). This should deflake the test_select_columns test. Signed-off-by: tmynn <[email protected]>
If a Ray error other than a
RayTaskError
is raisedThis PR fixes this by catching
RayError
in both cases, which is a superclass ofRayTaskError
,TaskCancelledError
, andWorkerCrashedError
(which may be raised during graceful task cancellation due to a Ray Core bug). This should deflake thetest_select_columns
test.Related issue number
Closes #30644
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.