-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AIR][DOC] Improved code snippet from TorchCheckpoint, removed angle brackets, and assert outputs #30791
Conversation
…assert output Signed-off-by: Jules Damji <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks great! There is still a little convincing of the CI to do I think before we can merge it :)
Is it possible that the CI wants you to do
instead of
? |
…cts output and ignores it with ELLIPSIS option Signed-off-by: Jules Damji <[email protected]>
Signed-off-by: Jules Damji <[email protected]>
@pcmoritz a bit weird that all local doctest pass, but somehow the ci-build-pr buildkite fails.... adding and removing the same lines ?? |
Signed-off-by: Jules Damji <[email protected]>
Signed-off-by: Jules Damji <[email protected]>
…brackets, and assert outputs (ray-project#30791) Signed-off-by: Jules Damji [email protected] As part of on-going effort to make code snippets runnable: Use testcode and testoput for CI Signed-off-by: Weichen Xu <[email protected]>
…brackets, and assert outputs (ray-project#30791) Signed-off-by: Jules Damji [email protected] As part of on-going effort to make code snippets runnable: Use testcode and testoput for CI Signed-off-by: tmynn <[email protected]>
Signed-off-by: Jules Damji [email protected]
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.