-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Bulk executor initial implementation #30903
Merged
Merged
Changes from all commits
Commits
Show all changes
152 commits
Select commit
Hold shift + click to select a range
9e4451e
copy prototype
ericl 8924a89
cleanup
ericl 44578ce
wip compatibility
ericl e0a346a
add basic wiring
ericl 22504c0
works
ericl 0b26570
fix up split handling
ericl 3f0e0cb
refactor legacy compat package
ericl eaa46b0
todo move operators fully
ericl 3162f44
reorganize opeators
ericl 2136170
stub out actors impl
ericl 38ae324
improve legacy integration
ericl 9f24555
add str
ericl f33c772
add own block propagation
ericl bf5288f
rename to tasks
ericl f5efe2c
add basic stats
ericl e5790dc
implement alltoall
ericl 5c7e490
revert format change
ericl d6bee3c
Merge remote-tracking branch 'upstream/master' into bulk-executor
ericl 1eb5519
fixme
ericl ec66fd0
fix
ericl 5aa082b
fix own propagation
ericl c8f8c79
add debug mem metrics
ericl 5b2f7ec
fix block clearing for datasetpipeline
ericl 00025f5
add config
ericl f8570ee
misc test fixes
ericl edba805
fix split memory free
ericl 683f4a1
workaround segfault
ericl a9c0bdf
wip
ericl db332e1
wip towards stats passing
ericl 07c0c69
improve logs
ericl e78e800
use bulk wait for performance
ericl 0fa159e
add ctrl-c support
ericl 2a9e0a5
rename
ericl 7573f99
rename node to op
ericl c00f867
wip
ericl 0ae94c7
Support block bundling
jianoaix 8c29abf
Block bundling: polish
jianoaix e6da60e
add mem tracing module
ericl a4faedc
flag protect tracing
ericl 6b9105a
Merge branch 'bulk-executor' of github.com:ericl/ray into bulk-executor
ericl a676598
Merge remote-tracking branch 'upstream/master' into bulk-executor
ericl 3427f90
add interfaces
ericl 224854c
Merge branch 'master' of https://github.com/ray-project/ray into bulk…
jianoaix ebf21e3
remove meta
ericl b5074e0
Merge branch 'master' of https://github.com/ray-project/ray into bulk…
jianoaix 51ceb36
add docstrings
ericl 4dad697
Merge branch 'interfaces-1' into bulk-executor
ericl d0769e3
remove input metadata
ericl 9695a27
remove hanging
ericl aab996e
fix gc failures
ericl 92f8b61
Merge remote-tracking branch 'upstream/master' into bulk-executor
ericl af3308b
fix size est tests
ericl a983e52
fix stats uuid handling
ericl da1ab6a
Merge branch 'bulk-executor' of github.com:ericl/ray into bulkexecuto…
jianoaix 01d4b2c
Block bundling: add more tests
jianoaix 808c82f
fix handling of randomize block stage ownership
ericl fa7e3ec
Merge branch 'bulk-executor' of github.com:ericl/ray into bulk-executor
ericl 44fb0f7
handle zero
ericl 964aaeb
Merge remote-tracking branch 'upstream/master' into bulk-executor
ericl 4567839
wip
ericl 23eea81
completion guarantee comments
ericl beba2a6
add assert too
ericl 887e4b3
Merge remote-tracking branch 'upstream/master' into bulk-executor
ericl f83edd9
add operators
ericl bc8f342
add test execution
ericl 50b456a
wip
ericl bdfef58
wip
ericl d810c61
add test todos
ericl 91b2848
add data stats todo
ericl 9e706ad
Merge remote-tracking branch 'upstream/master' into operators
ericl d3e370a
Merge remote-tracking branch 'upstream/master' into bulk-executor
ericl d4f514a
add basic tests
ericl cde12ec
add note
ericl b95a356
typo
ericl 1f15cd9
Merge branch 'operators' into bulk-executor
ericl 6129d66
fix tests
ericl ea62366
optimize function arg passing
ericl ab4e5d7
Merge remote-tracking branch 'upstream/master' into operators
ericl 510e748
Merge branch 'operators' into bulk-executor
ericl a6e8a18
comments
ericl 7eec78a
Merge branch 'operators' into bulk-executor
ericl bc021c9
comments 2
ericl cd0a902
Merge branch 'operators' into bulk-executor
ericl 718a32e
cleanup hierarchy
ericl f3d8a50
or zero
ericl 3228401
Apply suggestions from code review
ericl d1a98d6
Merge branch 'operators' of github.com:ericl/ray into operators
ericl 1a8dc02
min rows per bundle
ericl 203720e
fix tests
ericl f9850b4
Merge branch 'operators' into bulk-executor
ericl e1d2e89
last comment
ericl 690cb1d
Merge branch 'operators' into bulk-executor
ericl bf4ef1d
add min rows
ericl 0807aa9
Merge branch 'operators' into bulk-executor
ericl f7cd953
fix tests
ericl 1314dfb
Merge branch 'operators' into bulk-executor
ericl 4d94aed
Merge remote-tracking branch 'upstream/master' into operators
ericl 30c4486
Merge branch 'operators' into bulk-executor
ericl 1c83066
add exec impl
ericl 7cbfea4
lint
ericl f55101d
fix tests
ericl 3410619
lint
ericl 9f57758
check extra metrics
ericl f20fdc6
pull in optimization
ericl 0830f1e
add all to all test
ericl a607a3a
Merge branch 'part-4' into bulk-executor
ericl e3a6dd7
Merge remote-tracking branch 'upstream/master' into bulk-executor
ericl 19f0664
legacy compat
ericl be8b0d5
add split
ericl 341acb9
off by default
ericl 8dacdef
sanity test
ericl 6ea1cb8
update
ericl 9ac348b
Merge branch 'legacy-compat' into bulk-executor
ericl 597614a
wip port the old streaming prototype
ericl dbc2ebd
fix comments
ericl 458552f
add assert
ericl 53eb19d
Merge branch 'legacy-compat' into bulk-executor
ericl a16e2dc
Apply suggestions from code review
ericl 64849be
fix type
ericl 88cfd35
Merge remote-tracking branch 'upstream/master' into legacy-compat
ericl 965c0de
fix test
ericl 1dfe172
revert
ericl 7d8c2c9
Merge branch 'legacy-compat' into bulk-executor
ericl 25d0bb2
Merge remote-tracking branch 'upstream/master' into bulk-executor
ericl d789c9c
flip on
ericl 6cbbe8a
remove
ericl a119fc4
Merge remote-tracking branch 'upstream/master' into bulk-executor
ericl d4d2d0a
try removing buffer change
ericl 4462055
remove streaming executor
ericl 723241c
Merge branch 'master' of https://github.com/ray-project/ray into bulk…
jianoaix 64a1453
Merge branch 'master' of https://github.com/ray-project/ray into bulk…
jianoaix 2d554c5
Merge branch 'master' of https://github.com/ray-project/ray into bulk…
jianoaix 13852ec
Merge branch 'master' of https://github.com/ray-project/ray into bulk…
jianoaix 12c9eef
Merge branch 'master' of https://github.com/ray-project/ray into bulk…
jianoaix aef0530
Merge branch 'master' of https://github.com/ray-project/ray into bulk…
jianoaix 4242d72
extra metric
jianoaix 6540381
add __init__.py to operator packkage
jianoaix c446c58
Merge branch 'master' of https://github.com/ray-project/ray into bulk…
jianoaix 7c28ae3
Merge branch 'master' of https://github.com/ray-project/ray into bulk…
jianoaix 3467714
ray client block splitting
jianoaix a3bfe5b
Merge branch 'master' of https://github.com/ray-project/ray into bulk…
jianoaix 99e54da
Merge branch 'master' of https://github.com/ray-project/ray into bulk…
jianoaix 49691ae
Merge branch 'master' of https://github.com/ray-project/ray into bulk…
jianoaix 9358e1b
fix
jianoaix 199fe0e
fix stats
jianoaix c6e6a63
fix actorpool requiring num_cpus
jianoaix 06b1ad7
fix bazel test
jianoaix 3867061
Merge branch 'master' of https://github.com/ray-project/ray into bulk…
jianoaix 7097973
Merge branch 'master' of https://github.com/ray-project/ray into bulk…
jianoaix 0b74edf
minimize dif
jianoaix a9a66ab
less diff
jianoaix a265437
disable incremental take test
jianoaix File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jianoaix FYI I found these tests can sometimes spuriously pass with the timeout, if the first iteration never starts. I think it's safer to force a fixed number of iterations (e.g., 2 here), which would be enough to trigger spilling if GC wasn't working correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.