Revert "[AIR] Change ScalingConfig to be optional for DataParallelTrainers if already in Tuner param_space"
#30918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @justinvyu |
krfricke
approved these changes
Dec 6, 2022
justinvyu
added a commit
to justinvyu/ray
that referenced
this pull request
Dec 6, 2022
…ParallelTrainer`s if already in Tuner `param_space` (ray-project#30715)" (ray-project#30918)" This reverts commit df3628e.
krfricke
pushed a commit
that referenced
this pull request
Dec 7, 2022
…rallelTrainer`s if already in Tuner `param_space`"" (#30918) (#30920) #30715 introduced a test that was failing due to a change in master, and this PR wasn't fully up to date with master when the CI tests were all passing. Signed-off-by: Justin Yu <[email protected]>
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…Trainer`s if already in Tuner `param_space` (ray-project#30715)" (ray-project#30918) This reverts commit 626a05f. Signed-off-by: Weichen Xu <[email protected]>
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…rallelTrainer`s if already in Tuner `param_space`"" (ray-project#30918) (ray-project#30920) ray-project#30715 introduced a test that was failing due to a change in master, and this PR wasn't fully up to date with master when the CI tests were all passing. Signed-off-by: Justin Yu <[email protected]> Signed-off-by: Weichen Xu <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…Trainer`s if already in Tuner `param_space` (ray-project#30715)" (ray-project#30918) This reverts commit 626a05f. Signed-off-by: tmynn <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…rallelTrainer`s if already in Tuner `param_space`"" (ray-project#30918) (ray-project#30920) ray-project#30715 introduced a test that was failing due to a change in master, and this PR wasn't fully up to date with master when the CI tests were all passing. Signed-off-by: Justin Yu <[email protected]> Signed-off-by: tmynn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #30715 due to CI failure https://buildkite.com/ray-project/oss-ci-build-branch/builds/1416