[Train] HuggingFacePredictor & docs improvements
#30945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antoni Baum <[email protected]>
Signed-off-by: Antoni Baum <[email protected]>
Signed-off-by: Antoni Baum <[email protected]>
amogkam
reviewed
Dec 7, 2022
amogkam
reviewed
Dec 9, 2022
| dataset = ray.data.from_numpy(prompts.to_numpy().astype("U")) | ||
| elif batch_type == pd.DataFrame: | ||
| dataset = ray.data.from_pandas(prompts) | ||
| elif batch_type == pa.Table: |
There was a problem hiding this comment.
let's remove arrow if it's no longer being supported?
There was a problem hiding this comment.
It's in multiple tests - we should do this in a separate PR
Signed-off-by: Antoni Baum <[email protected]>
amogkam
approved these changes
Dec 9, 2022
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
This PR introduces 2 changes: Removes a confusing suggestion in the docstring of HuggingFaceCheckpoint - checkpoints created using from_checkpoint will not work for prediction as intended. Adds use_gpu argument and logic to automatically use GPU if one is available to HuggingFacePredictor. Signed-off-by: Antoni Baum <[email protected]> Signed-off-by: Weichen Xu <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
This PR introduces 2 changes: Removes a confusing suggestion in the docstring of HuggingFaceCheckpoint - checkpoints created using from_checkpoint will not work for prediction as intended. Adds use_gpu argument and logic to automatically use GPU if one is available to HuggingFacePredictor. Signed-off-by: Antoni Baum <[email protected]> Signed-off-by: tmynn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR introduces 2 changes:
HuggingFaceCheckpoint- checkpoints created usingfrom_checkpointwill not work for prediction as intended.use_gpuargument and logic to automatically use GPU if one is available toHuggingFacePredictor.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.