Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Deprecate (delete) contrib folder. #30992

Merged
merged 11 commits into from
Dec 15, 2022

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Dec 9, 2022

Signed-off-by: sven1977 [email protected]

Deprecate (delete) the rllib/contrib folder.

Contributors that would like to contribue algorithms should do so directly via PRs in the rllib/algorithms package, loosely following this PR here by @Capiru #30651

We'll also add a new user guide soon describing how to contribute entire algorithms to RLlib to our docs.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 requested a review from a team as a code owner December 15, 2022 12:49
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 merged commit 64d744b into ray-project:master Dec 15, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
@sven1977 sven1977 deleted the deprecate_contrib_folder branch June 2, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants