[RLlib] Better behavior if user does not specify stopping condition in RLLib CLI #31078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
ArturNiederfahrenhorst
requested review from
sven1977,
gjoliver,
avnishn,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
maxpumperla
reviewed
Dec 14, 2022
rllib/common.py
Outdated
| @@ -216,7 +218,7 @@ class CLIArguments: | |||
|
|
|||
| # Train arguments | |||
| # __cli_train_start__ | |||
| Stop = typer.Option(None, "--stop", "-s", help=get_help("stop")) | |||
| Stop = typer.Option(None, *STOP_ARG_NAMES, help=get_help("stop")) | |||
There was a problem hiding this comment.
@ArturNiederfahrenhorst hmm, I think you can fix all of this by making the default arg "{}" instead of None
maxpumperla
requested changes
Dec 14, 2022
There was a problem hiding this comment.
great, thanks for spotting this @ArturNiederfahrenhorst! I think we can simplify
Signed-off-by: Artur Niederfahrenhorst <[email protected]>
|
@maxpumperla I have also removed the warning I introduced about stop being empty to simplify this. |
|
@ArturNiederfahrenhorst I think we can add this to the typer help of the stop command, if not already there |
maxpumperla
approved these changes
Dec 14, 2022
|
@maxpumperla Info on how to use stop is already in the help string. I'll leave it there and not warn users when it's missing. |
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…n RLLib CLI. (ray-project#31078) Signed-off-by: Weichen Xu <[email protected]>
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…n RLLib CLI. (ray-project#31078) Signed-off-by: tmynn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artur Niederfahrenhorst [email protected]
Why are these changes needed?
We have lots of examples inside RLlib of running ray CLI similar to
rllib train --env ... --config ...that lack a stopping condition.They error out with the following message.
We should not error out, since a workflow to be expected from us is to quickly start an experiment from CLI, observe it and cancel it manually without caring for stopping condidations.
Related issue number
https://discuss.ray.io/t/problem-with-rllib-configuration-by-command-line/8624
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.