Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Issue 30394: Add proper __str__ method to PolicyMap. #31098

Merged
merged 1 commit into from
Dec 16, 2022
Merged

[RLlib] Issue 30394: Add proper __str__ method to PolicyMap. #31098

merged 1 commit into from
Dec 16, 2022

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Dec 14, 2022 •
edited
Loading

Signed-off-by: sven1977 [email protected]

Issue 30394: Add proper __str__ method to PolicyMap.

Closes #30394

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
5ff7251 
Signed-off-by: sven1977 <[email protected]>
@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Dec 15, 2022
kouroshHakha
kouroshHakha approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@kouroshHakha kouroshHakha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sven1977 sven1977 merged commit 59d43df into ray-project:master Dec 16, 2022
WeichenXu123 pushed a commit to WeichenXu123/ray that referenced this pull request Dec 19, 2022
@sven1977 @WeichenXu123
[RLlib] Issue 30394: Add proper __str__() method to PolicyMap. (ray…
0773214 
…-project#31098)

Signed-off-by: Weichen Xu <[email protected]>
AmeerHajAli pushed a commit that referenced this pull request Jan 12, 2023
@sven1977 @AmeerHajAli
[RLlib] Issue 30394: Add proper __str__() method to PolicyMap. (#31098
faf80f1 
)
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
@sven1977 @tamohannes
[RLlib] Issue 30394: Add proper __str__() method to PolicyMap. (ray…
d2f6a07 
…-project#31098)

Signed-off-by: tmynn <[email protected]>
@sven1977 sven1977 deleted the issue_30394_policy_map_needs_better_repr_method branch June 2, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kouroshHakha kouroshHakha kouroshHakha approved these changes

@gjoliver gjoliver Awaiting requested review from gjoliver

@avnishn avnishn Awaiting requested review from avnishn

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

@smorad smorad Awaiting requested review from smorad

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@kouroshHakha kouroshHakha

Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RLLib] DefaultCallbacks returning an empty policy dictionary
2 participants
@sven1977 @kouroshHakha