[tune/release] Wait for final experiment checkpoint sync to finish #31131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
…y_tune_cloud_gcp
krfricke
approved these changes
Dec 16, 2022
Yes, I tested both fixes in isolation and they resolved the issue. The forced checkpoint frequency deflaking this test seems to be dependent on the Ex: With
|
…y_tune_cloud_gcp Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
…y_tune_cloud_gcp
|
Awesome, I'm running the release test now and will merge once it passes. https://buildkite.com/ray-project/release-tests-pr/builds/24195 |
This was referenced Jan 6, 2023
Closed
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
…31131) This PR includes fixes to deflake the `tune_cloud_gcp_k8s_durable_upload` release test, including (1) including a wait for the final experiment checkpoint sync to finish and (2) fixing forced checkpointing frequency logic. Signed-off-by: Justin Yu <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…ay-project#31131) This PR includes fixes to deflake the `tune_cloud_gcp_k8s_durable_upload` release test, including (1) including a wait for the final experiment checkpoint sync to finish and (2) fixing forced checkpointing frequency logic. Signed-off-by: Justin Yu <[email protected]> Signed-off-by: tmynn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes fixes to deflake the
tune_cloud_gcp_k8s_durable_uploadrelease test, including (1) including a wait for the final experiment checkpoint sync to finish and (2) fixing forced checkpointing frequency logic.Why are these changes needed?
Problem causing the
tune_cloud_gcp_k8s_durable_uploadrelease test to be flaky:Sync commands are now run as daemon threads from ed5b9e5, and they don't wait to be finished when launched at the end of the Tune experiment (triggered by the interrupt).
Another fix this PR includes is: the forced checkpoint frequency (based on
num_to_keep) has a one off error right now, so it's not forcing experiment checkpointing as frequently as it should.TODO
Related issue number
#30353
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.