[RLlib] Policy mapping fn can not be called with keyword arguments. #31141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjoliver
requested review from
sven1977,
avnishn,
ArturNiederfahrenhorst,
smorad,
maxpumperla,
kouroshHakha and
krfricke
as code owners
kouroshHakha
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
I guess we never tested custom policy_mapping_fn with enable_connector? :)
Wow to the fact that this last test that @sven1977 added caught this mismatch.
Signed-off-by: Jun Gong <[email protected]>
gjoliver
force-pushed
the
policy_mapping_fn_param
branch
from
75adfdc
to
3834bf4
Compare
I am often amazed by our unit test coverage actually ... |
added 4 commits
December 15, 2022 15:33
Signed-off-by: Jun Gong <[email protected]>
Signed-off-by: Jun Gong <[email protected]>
Signed-off-by: Jun Gong <[email protected]>
Signed-off-by: Jun Gong <[email protected]>
|
tests look good, I will merge. |
WeichenXu123
pushed a commit
to WeichenXu123/ray
that referenced
this pull request
Dec 19, 2022
…ay-project#31141) Signed-off-by: Jun Gong <[email protected]> Signed-off-by: Weichen Xu <[email protected]>
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
…31141) Signed-off-by: Jun Gong <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…ay-project#31141) Signed-off-by: Jun Gong <[email protected]> Signed-off-by: tmynn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jun Gong [email protected]
Why are these changes needed?
There is no published spec for the parameter names.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.