[Tune] Fix AxSearch save and nan/inf result handling #31147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Yu <[email protected]>
…lambdas) Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
Signed-off-by: Justin Yu <[email protected]>
justinvyu
force-pushed
the
ax_search_fixes
branch
from
86559d2
to
4555861
Compare
krfricke
approved these changes
Dec 22, 2022
7 tasks
krfricke
pushed a commit
that referenced
this pull request
Jan 9, 2023
Skips a zoopt searcher test that's causing the `test_searchers` suite in CI to be flaky. Skipping as this is not a Tune issue and needs to be fixed in the zoopt library. I re-enabled this test in #31147 since I thought that nan/inf error handling had been fixed in a recent zoopt release. However, nan/inf values will still cause an error if reported on trial complete. This test should be enabled after polixir/ZOOpt#7 is included in the next zoopt release. Signed-off-by: Justin Yu <[email protected]>
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
This PR fixes AxSearch saving and handles trials that produce nan/inf metrics properly. Signed-off-by: Justin Yu <[email protected]>
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
Skips a zoopt searcher test that's causing the `test_searchers` suite in CI to be flaky. Skipping as this is not a Tune issue and needs to be fixed in the zoopt library. I re-enabled this test in #31147 since I thought that nan/inf error handling had been fixed in a recent zoopt release. However, nan/inf values will still cause an error if reported on trial complete. This test should be enabled after polixir/ZOOpt#7 is included in the next zoopt release. Signed-off-by: Justin Yu <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
This PR fixes AxSearch saving and handles trials that produce nan/inf metrics properly. Signed-off-by: Justin Yu <[email protected]> Signed-off-by: tmynn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes AxSearch saving and handles trials that produce nan/inf metrics properly.
Why are these changes needed?
Issues
AxSearchsaving fails during experiment checkpointing. This wasn't caught because it's (1) just a warning, and (2) the unit test didn't actually start fitting/saving any models for config suggestion, sincenum_sampleswas too low. This is fixed by using cloudpickle during AxSearch save.AxSearchdoesn't handle nan/inf metric values (will raise an input error on both of these). This PR screens these out and usesAxClient.abandon_trialto complete this trial without adding its result as data to fit on. This wasn't caught for a similar reason to above.Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.