[Datasets] Fix to_tf when the input feature_columns is a list.
#31228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jeroen Bédorf <[email protected]>
Co-authored-by: Jeroen Bédorf <[email protected]>
add re3 documentation
Signed-off-by: n3011 <[email protected]>
n30111
requested review from
ericl,
scv119,
clarkzinzow,
jjyao,
jianoaix and
c21
as code owners
bveeramani
requested changes
Dec 20, 2022
Signed-off-by: n3011 <[email protected]>
|
@bveeramani thanks, I have added a test to verify the above change. |
clarkzinzow
approved these changes
Dec 21, 2022
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
…-project#31228) This fixes a bug in dataset.to_tf method. This method should returns a dictionary when input feature_columns is a list, but in the current release 2.2 and master branch it is returning a set, which also fails due to unhashable type. Signed-off-by: tmynn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This fixes a bug in
dataset.to_tfmethod. This method should returns a dictionary when input feature_columns is a list, but in the current release 2.2 and master branch it is returning a set, which also fails due to unhashable type.Related issue number
#31229
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.