[autoscaler] Make NodeLaunchException serializable #31256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 20, 2022 15:49
rkooo567
approved these changes
Dec 21, 2022
DmitriGekhtman
approved these changes
Dec 21, 2022
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
In order to make node launch exceptions serializable, drop the optional stack trace which isn't serializable. Co-authored-by: Alex <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
In order to make node launch exceptions serializable, drop the optional stack trace which isn't serializable. Co-authored-by: Alex <[email protected]> Signed-off-by: tmynn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
In order to make node launch exceptions serializable, drop the optional stack trace which isn't serializable.
Related issue number
Closes #31254
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.