-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core][state] Task events backend - Port state API [5/n] #31278
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rickyyx <[email protected]>
Signed-off-by: rickyyx <[email protected]>
Signed-off-by: rickyyx <[email protected]>
Signed-off-by: rickyyx <[email protected]>
Signed-off-by: rickyyx <[email protected]>
rickyyx
requested review from
wuisawesome,
ericl,
AmeerHajAli,
robertnishihara,
pcmoritz,
raulchen,
fishbone and
scv119
as code owners
December 22, 2022 20:20
Could we split out the unrelated changes to TaskManager? These are high-risk changes, so we should review them independently of the status API. |
ericl
added
the
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
label
Dec 22, 2022
Signed-off-by: rickyyx <[email protected]>
Signed-off-by: rickyyx <[email protected]>
rickyyx
removed
the
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
label
Dec 22, 2022
ericl
approved these changes
Dec 22, 2022
ericl
added
the
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
label
Dec 22, 2022
Signed-off-by: rickyyx <[email protected]>
rickyyx
removed
the
@author-action-required
The PR author is responsible for the next step. Remove tag to send back to the reviewer.
label
Dec 22, 2022
rickyyx
changed the title
[core][state] Task backend - Port state API [6/n]
[core][state] Task backend - Port state API [5/n]
Dec 23, 2022
7 tasks
rickyyx
changed the title
[core][state] Task backend - Port state API [5/n]
[core][state] Task events backend - Port state API [5/n]
Dec 23, 2022
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
**Previous PRs:** - #30829: - #30953: - #30867: - #30979: - #30934 - #31207 **This PR:** With the change, - `list_tasks` now will return tasks with attempt number as an additional column. - `get_task` might return multiple task attempt entries if there are retries. There is also some plumbing in the test and in core (esp in the test logic) given the changes. Major changes in the PR are: - Add limit support to `GcsTaskManager` - Change the state aggregator to get tasks from GCS.
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
**Previous PRs:** - ray-project#30829: - ray-project#30953: - ray-project#30867: - ray-project#30979: - ray-project#30934 - ray-project#31207 **This PR:** With the change, - `list_tasks` now will return tasks with attempt number as an additional column. - `get_task` might return multiple task attempt entries if there are retries. There is also some plumbing in the test and in core (esp in the test logic) given the changes. Major changes in the PR are: - Add limit support to `GcsTaskManager` - Change the state aggregator to get tasks from GCS. Signed-off-by: tmynn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: rickyyx [email protected]
Why are these changes needed?
Previous PRs:
This PR:
With the change,
list_tasks
now will return tasks with attempt number as an additional column.get_task
might return multiple task attempt entries if there are retries.There is also some plumbing in the test and in core (esp in the test logic) given the changes. Major changes in the PR are:
GcsTaskManager
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.