Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Issue 28428: QMix not working w/ GPUs. #31299

Merged
merged 1 commit into from
Jan 3, 2023
Merged

[RLlib] Issue 28428: QMix not working w/ GPUs. #31299

merged 1 commit into from
Jan 3, 2023

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Dec 22, 2022 •
edited
Loading

Signed-off-by: sven1977 [email protected]

Issue 28428: QMix not working w/ GPUs.

Closes #28428

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
LINT
3369037 
Signed-off-by: sven1977 <[email protected]>
avnishn
avnishn approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@avnishn avnishn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. we can bring this up to speed after we move to the new training api

@sven1977 sven1977 merged commit cfa4dd8 into ray-project:master Jan 3, 2023
@sven1977 sven1977 deleted the issue_28428_qmix_not_working_with_gpus branch January 3, 2023 18:35
AmeerHajAli pushed a commit that referenced this pull request Jan 12, 2023
@sven1977 @AmeerHajAli
[RLlib] Issue 28428: QMix not working w/ GPUs. (#31299)
5d2a390
tamohannes pushed a commit to ju2ez/ray that referenced this pull request Jan 25, 2023
@sven1977 @tamohannes
[RLlib] Issue 28428: QMix not working w/ GPUs. (ray-project#31299)
933a07a 
Signed-off-by: tmynn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avnishn avnishn avnishn approved these changes

@gjoliver gjoliver Awaiting requested review from gjoliver

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

@smorad smorad Awaiting requested review from smorad

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha

@krfricke krfricke Awaiting requested review from krfricke

Assignees

@avnishn avnishn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RLlib] QMix accepts GPUs > 0 but errors out
2 participants
@sven1977 @avnishn