[Serve] Address incremental memory leak due to _PyObjScanner #31317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: simon-mo [email protected]
Why are these changes needed?
Ray user @AbhishekBose reported a memory leak in Ray Serve and I was able to pin it down to the the leak in the
PyObjScanner
object. Previously we had to deal with this in other places. But it seems like the fix was incomplete.This PR apply the same fix to the other places where _PyObjScanner is involved. Someone from the Ray Serve team should follow up with a release test.
Related issue number
https://discuss.ray.io/t/dagdriver-memory-increasing-for-basic-dags/8758/1
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.