[Datasets] Allow MultiHotEncoder to encode arrays
#31365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Balaji Veeramani <[email protected]>
bveeramani
requested review from
clarkzinzow,
jiaodong,
Yard1,
matthewdeng,
amogkam,
ericl,
scv119,
jjyao,
jianoaix and
c21
as code owners
Yard1
approved these changes
Dec 30, 2022
jiaodong
reviewed
Dec 30, 2022
amogkam
approved these changes
Dec 31, 2022
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
MultiHotEncoder doesn't work with Arrow datasets. This PR updates the MultiHotEncoder implementation to fix the issue. Signed-off-by: Balaji Veeramani <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
MultiHotEncoder doesn't work with Arrow datasets. This PR updates the MultiHotEncoder implementation to fix the issue. Signed-off-by: Balaji Veeramani <[email protected]> Signed-off-by: tmynn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Balaji Veeramani [email protected]
Why are these changes needed?
tl;dr:
MultiHotEncoderdoesn't work with Arrow datasets. This PR updates theMultiHotEncoderimplementation to fix the issue.MultiHotEncoderimplements the_transform_pandasmethod. So, whenMultiHotEncodertransforms a dataset, it converts Arrow blocks to pandas DataFrames. During the conversion, lists are converted to ndarrays. This causesMultiHotEncoderto error, becauseMultiHotEncoderdoesn't support ndarrays (only built-in lists).Related issue number
Fixes #31353
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.