[Data] Fix Discretizers transforming ignored cols #31404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antoni Baum <[email protected]>
Yard1
requested review from
bveeramani,
matthewdeng,
amogkam,
ericl,
scv119,
jjyao,
jianoaix and
c21
as code owners
clarkzinzow
approved these changes
Jan 3, 2023
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
Signed-off-by: Antoni Baum <[email protected]> This PR fixes a bug in Discretizer Preprocessors where all of the columns in a Dataset would be transformed instead of just the specified ones. This lead to exceptions due to KeyErrors later.
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
Signed-off-by: Antoni Baum <[email protected]> This PR fixes a bug in Discretizer Preprocessors where all of the columns in a Dataset would be transformed instead of just the specified ones. This lead to exceptions due to KeyErrors later. Signed-off-by: tmynn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Antoni Baum [email protected]
Why are these changes needed?
This PR fixes a bug in Discretizer Preprocessors where all of the columns in a Dataset would be transformed instead of just the specified ones. This lead to exceptions due to KeyErrors later.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.