[Datasets] Fix the bug of eagerly clearing up input blocks #31459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Clark Zinzow <[email protected]> Signed-off-by: Cheng Su <[email protected]>
c21
requested review from
ericl,
scv119,
clarkzinzow,
jjyao and
jianoaix
as code owners
13 tasks
clarkzinzow
approved these changes
Jan 5, 2023
| # Test that first map is executed twice, because ds1.fully_executed() | ||
| # clears up the previous snapshot blocks, and ds2.fully_executed() | ||
| # has to re-execute ds.map(inc) again. | ||
| assert ray.get(map_counter.get.remote()) == 2 * 10 + 10 + 10 |
| # If not a lazy datasource, unlink the input blocks from the plan so we | ||
| # can eagerly reclaim the input block memory after the first stage is | ||
| # done executing. | ||
| self._in_blocks = None |
There was a problem hiding this comment.
I think that removing this is safe, but when adding the block clearing logic for the new execution plan/model, we should be sure to have comprehensive memory releasing tests that covers all corners cases of our block clearing semantics.
jianoaix
approved these changes
Jan 5, 2023
ericl
pushed a commit
that referenced
this pull request
Jan 6, 2023
This PR is to enable lazy execution by default. See ray-project/enhancements#19 for motivation. The change includes: * Change `Dataset` constructor: `Dataset.__init__(lazy: bool = True)`. Also remove `defer_execution` field, as it's no longer needed. * `read_api.py:read_datasource()` returns a lazy `Dataset` with computing the first input block. * Add `ds.fully_executed()` calls to required unit tests, to make sure they are passing. TODO: - [x] Fix all unit tests - [x] #31459 - [x] #31460 - [ ] Remove the behavior to eagerly compute first block for read - [ ] #31417 - [ ] Update documentation
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
This PR is fixing the issue found in #31286. Previously we always eagerly clears up non-lazy input blocks (plan._in_blocks) when executing the plan. This is not safe as the input blocks might be used by downstream operations later. Signed-off-by: Cheng Su <[email protected]> Co-authored-by: Clark Zinzow <[email protected]>
AmeerHajAli
pushed a commit
that referenced
this pull request
Jan 12, 2023
This PR is to enable lazy execution by default. See ray-project/enhancements#19 for motivation. The change includes: * Change `Dataset` constructor: `Dataset.__init__(lazy: bool = True)`. Also remove `defer_execution` field, as it's no longer needed. * `read_api.py:read_datasource()` returns a lazy `Dataset` with computing the first input block. * Add `ds.fully_executed()` calls to required unit tests, to make sure they are passing. TODO: - [x] Fix all unit tests - [x] #31459 - [x] #31460 - [ ] Remove the behavior to eagerly compute first block for read - [ ] #31417 - [ ] Update documentation
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
This PR is fixing the issue found in ray-project#31286. Previously we always eagerly clears up non-lazy input blocks (plan._in_blocks) when executing the plan. This is not safe as the input blocks might be used by downstream operations later. Signed-off-by: Cheng Su <[email protected]> Co-authored-by: Clark Zinzow <[email protected]> Signed-off-by: tmynn <[email protected]>
tamohannes
pushed a commit
to ju2ez/ray
that referenced
this pull request
Jan 25, 2023
This PR is to enable lazy execution by default. See ray-project/enhancements#19 for motivation. The change includes: * Change `Dataset` constructor: `Dataset.__init__(lazy: bool = True)`. Also remove `defer_execution` field, as it's no longer needed. * `read_api.py:read_datasource()` returns a lazy `Dataset` with computing the first input block. * Add `ds.fully_executed()` calls to required unit tests, to make sure they are passing. TODO: - [x] Fix all unit tests - [x] ray-project#31459 - [x] ray-project#31460 - [ ] Remove the behavior to eagerly compute first block for read - [ ] ray-project#31417 - [ ] Update documentation Signed-off-by: tmynn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Clark Zinzow [email protected]
Signed-off-by: Cheng Su [email protected]
Why are these changes needed?
This PR is fixing the issue found in #31286. Previously we always eagerly clears up non-lazy input blocks (
plan._in_blocks) when executing the plan. This is not safe as the input blocks might be used by downstream operations later.An example of exception:
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.